-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting metrics messages in Beats logs #36163
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
@ycombinator Thanks for opening this!
|
Yes, please! There are a number of things that will need fixing / improving in this PR and I'd be grateful if you could help with that by directly pushing commits to my branch. I'll add some PR comments in the areas I'd like your help.
Yes, I think that's fine, although if you think we should shorten that tile so it fits better with the rest of its sibling nav items, feel free to make the necessary edits. Thanks! |
|
||
[id="understand-{beatname_lc}-logs"] | ||
[role="xpack"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: what does this line do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't do anything, and rather it's just a leftover from when we had to identified X-pack content. I left it in when I copied the content over from the other docs page just because I'm not 100% sure it's not used anymore.
Sounds good @ycombinator
I'll still have some suggestions for the wording so I'll add those probably later in the day tomorrow. |
Here's a preview showing Filebeat versus non-Filebeat: |
Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Craig MacKenzie <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thank you for writing this up!
@lucabelluccini FYI this is likely helpful for support. |
The published version is at https://www.elastic.co/guide/en/beats/filebeat/master/understand-filebeat-logs.html |
Lovely @ycombinator ! Thank you for the notification @cmacknz |
## What does this PR do? This PR documents the metrics that are periodically emitted by Beats in their logs. <!-- Mandatory Explain here the changes you made on the PR. Please explain the WHAT: patterns used, algorithms implemented, design architecture, message processing, etc. --> ## Why is it important? To understand what the metrics mean and how they could be used for troubleshooting. <!-- Mandatory Explain here the WHY, or the rationale/motivation for the changes. --> --------- Co-authored-by: David Kilfoyle <[email protected]> Co-authored-by: David Kilfoyle <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]>
What does this PR do?
This PR documents the metrics that are periodically emitted by Beats in their logs.
Why is it important?
To understand what the metrics mean and how they could be used for troubleshooting.