-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns processor - Add A, AAAA, and TXT query support #36394
dns processor - Add A, AAAA, and TXT query support #36394
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
The dns processor previously supported only reverse DNS lookups. This adds support for performing A, AAAA, and TXT record queries. The response.ptr.histogram metric was renamed to request_duration.histogram. This naming allows the metric to represent the duration of the DNS request for all query types. Closes elastic#11416
4598a67
to
6ccdfdf
Compare
6ccdfdf
to
64b7032
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
||
// Unpack unpacks a string to a queryType. | ||
func (qt *queryType) Unpack(v string) error { | ||
switch strings.ToLower(v) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use strings.EqualFold
? It's more verbose, so up to you.
Co-authored-by: Dan Kortschak <[email protected]>
The dns processor previously supported only reverse DNS lookups. This adds support for performing A, AAAA, and TXT record queries. The response.ptr.histogram metric was renamed to request_duration.histogram. This naming allows the metric to represent the duration of the DNS request for all query types. Some refactoring was done to unexport types/functions that should have been internal only. Closes elastic#11416 Co-authored-by: Dan Kortschak <[email protected]>
Proposed commit message
The dns processor previously supported only reverse DNS lookups.
This adds support for performing A, AAAA, and TXT record queries.
The
response.ptr.histogram
metric was renamed torequest_duration.histogram
.This naming allows the metric to represent the duration of the DNS request
for all query types.
Closes #11416
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Examples
filebeat.yml
:output events:
% jq .processor dns-stats.json