Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metricbeat k6 module #38179

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Add metricbeat k6 module #38179

wants to merge 22 commits into from

Conversation

zeynepyz
Copy link

@zeynepyz zeynepyz commented Mar 4, 2024

Proposed commit message

I created new metricbeat module named k6. It takes k6 metrics via Rest API and indexes them then send them to elasticsearch. While doing this project, I schematized the metrics using mapstr. I am trying to improve myself and i want my github to fill with good projects that's why i did this.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

This is the expected error when k6 is not running.

Screenshot from 2024-01-29 10-01-56

Logs

This will show that the k6 module is working. You will receive metrics too.

{"log.level":"warn","@timestamp":"2024-03-04T22:01:07.399+0300","log.logger":"cfgwarn","log.origin":{"function":"github.com/elastic/beats/v7/metricbeat/module/k6/k6metricset.New","file.name":"k6metricset/k6metricset.go","file.line":65},"message":"BETA: The k6 k6metricset metricset is beta.","service.name":"metricbeat","ecs.version":"1.6.0"}

@zeynepyz zeynepyz requested review from a team as code owners March 4, 2024 19:05
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2024
Copy link

cla-checker-service bot commented Mar 4, 2024

💚 CLA has been signed

Copy link
Contributor

mergify bot commented Mar 4, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zeynepyz? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@zeynepyz zeynepyz changed the title I created nev metricbeat module for k6 I created new metricbeat module for k6 Mar 4, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2024

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-14T09:23:25.886+0000

  • Duration: 7 min 38 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/beats.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/zeynepyz return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zeynepyz : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zeynepyz : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Mar 5, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2024
@zeynepyz zeynepyz requested a review from a team as a code owner March 10, 2024 10:35
Copy link
Contributor

mergify bot commented Mar 28, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b deneme upstream/deneme
git merge upstream/main
git push upstream deneme

@zeynepyz zeynepyz changed the title I created new metricbeat module for k6 Add metricbeat k6 module Mar 28, 2024
@cmacknz cmacknz added Team:Service-Integrations Label for the Service Integrations team and removed Team:Elastic-Agent Label for the Agent team labels Apr 2, 2024
@zeynepyz zeynepyz requested review from a team as code owners April 7, 2024 12:33
@botelastic botelastic bot added the Team:Automation Label for the Observability productivity team label Apr 7, 2024
Copy link
Contributor

mergify bot commented Apr 7, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b deneme upstream/deneme
git merge upstream/main
git push upstream deneme

@zeynepyz
Copy link
Author

hi i passed the tests what should i do now?

Copy link
Contributor

mergify bot commented Sep 29, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Automation Label for the Observability productivity team Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants