x-pack/filebeat/input/{cel,websocket}: prevent addition of regexp extension when no patterns are provided #38181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
botelastic
bot
added
needs_team
…ention when no patterns are provided In the case of cel, the extension was always being added, and then was conditionally added when a pattern was configured, resulting in an failed configuration. In the case of websocket the conditional addition was not being performed, so no failure occured, but additional look-up load was being added. So unify the approaches to the correct conditional addition.
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
changed the title
andrewkroh
approved these changes
Mar 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
…ension when no patterns are provided (#38181) In the case of cel, the extension was always being added, and then was conditionally added when a pattern was configured, resulting in a failed configuration. In the case of websocket the conditional addition was not being performed, so no failure occurred, but additional look-up load was being added. So unify the approaches to the correct conditional addition. (cherry picked from commit 0797a64)
efd6
added a commit
that referenced
this pull request
Mar 6, 2024
…ension when no patterns are provided (#38181) (#38192) In the case of cel, the extension was always being added, and then was conditionally added when a pattern was configured, resulting in a failed configuration. In the case of websocket the conditional addition was not being performed, so no failure occurred, but additional look-up load was being added. So unify the approaches to the correct conditional addition. (cherry picked from commit 0797a64) Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In the case of cel, the extension was always being added, and then was conditionally added when a pattern was configured, resulting in a failed configuration. In the case of websocket the conditional addition was not being performed, so no failure occured, but additional look-up load was being added. So unify the approaches to the correct conditional addition.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs