Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Support VPC endpoint for aws-s3 input SQS queue url #38189

Merged
merged 10 commits into from
Mar 19, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 5, 2024

Proposed commit message

This PR is to add support for VPC endpoint in aws-s3 input with SQS setup. AWS customers can now access Amazon Simple Queue Service (Amazon SQS) from their Amazon Virtual Private Cloud (Amazon VPC) using VPC endpoints.
Previously we only supported SQS endpoint directly in the format like this: https://sqs.{REGION_ENDPOINT}.{ENDPOINT}/{ACCOUNT_NUMBER}/{QUEUE_NAME}.
Now with VPC, we will also support endpoint format like this: https://{VPC_ENDPOINT}.sqs.{REGION_ENDPOINT}.vpce.{ENDPOINT}/{ACCOUNT_NUMBER}/{QUEUE_NAME}

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2024
Copy link
Contributor

mergify bot commented Mar 5, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 5, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-03-18T22:38:08.522+0000

  • Duration: 140 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 3320
Skipped 180
Total 3500

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review March 6, 2024 22:13
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner March 6, 2024 22:13
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Mar 6, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2024
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024

@kaiyan-sheng kaiyan-sheng merged commit 4a3da80 into elastic:main Mar 19, 2024
39 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws] Support VPC endpoint for aws-s3 input SQS queue url
3 participants