Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/etw: Rename activity_guid to activity_id in ETW events #38530

Merged
merged 4 commits into from
Mar 25, 2024
Merged

x-pack/filebeat/input/etw: Rename activity_guid to activity_id in ETW events #38530

merged 4 commits into from
Mar 25, 2024

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented Mar 21, 2024 •
edited
Loading

Proposed commit message

Rename activity_guid to activity_id in generated ETW events to match mapping and other Windows inputs.

It also fixes some typos in the ETW docs and comments.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@chemamartinez chemamartinez added bugfix Input:etw Related issues to the Event Tracing for Windows input backport-v8.13.0 Automated backport with mergify labels Mar 21, 2024
@chemamartinez chemamartinez self-assigned this Mar 21, 2024
@chemamartinez chemamartinez requested a review from a team as a code owner March 21, 2024 15:47
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2024
@botelastic
Copy link

botelastic bot commented Mar 21, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 21, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 11 min 32 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @chemamartinez

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chemamartinez

@chemamartinez
Copy link
Contributor Author

/test

andrewkroh
andrewkroh approved these changes Mar 22, 2024
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@chemamartinez
Copy link
Contributor Author

/test

@chemamartinez chemamartinez merged commit fe132da into main Mar 25, 2024
44 of 46 checks passed
@chemamartinez chemamartinez deleted the fix-etw-activity-id branch March 25, 2024 11:31
mergify bot pushed a commit that referenced this pull request Mar 25, 2024
@chemamartinez @mergify
x-pack/filebeat/input/etw: Rename activity_guid to activity_id in ETW…
6437e86 
… events (#38530)

Rename activity_guid to activity_id in generated ETW events to match mapping and other Windows inputs.

(cherry picked from commit fe132da)

# Conflicts:
#	x-pack/filebeat/docs/inputs/input-etw.asciidoc
@mergify mergify bot mentioned this pull request Mar 25, 2024
Closed
6 tasks
belimawr pushed a commit to belimawr/beats that referenced this pull request Mar 26, 2024
@chemamartinez @belimawr
x-pack/filebeat/input/etw: Rename activity_guid to activity_id in ETW…
a462d0f 
… events (elastic#38530)

Rename activity_guid to activity_id in generated ETW events to match mapping and other Windows inputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@chemamartinez chemamartinez

Labels
backport-v8.13.0 Automated backport with mergify bugfix Input:etw Related issues to the Event Tracing for Windows input needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chemamartinez @elasticmachine @andrewkroh