-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/{cel,httpjson}: fix oauth2 config validation #38962
Conversation
74176a7
to
5949d94
Compare
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
This pull request is now in conflicts. Could you fix it? 🙏
|
The logic for validation assumed that client.id and client.secret must be present, but this is not the case for password grant, so relax the requirement.
5949d94
to
0a7e95e
Compare
…th2 config validation (#38995) * x-pack/filebeat/input/{cel,httpjson}: fix oauth2 config validation (#38962) The logic for validation assumed that client.id and client.secret must be present, but this is not the case for password grant, so relax the requirement. (cherry picked from commit aae9185) * remove irrelevant changelog entries --------- Co-authored-by: Dan Kortschak <[email protected]>
Proposed commit message
The logic for validation assumed that client.id and client.secret must be present, but this is not the case for password grant, so relax the requirement.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs