Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/gcppubsub: Prevent input blockage by increasing default max_outstanding_messages #38985

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Apr 16, 2024

Proposed commit message

  • Due to the presence of internal queue, the input gets blocked until queue.mem.flush.min_events or queue.mem.flush.timeout is reached. To prevent this blockage on GCP Pub/Sub input, default max_outstanding_messages is increased to at least queue.mem.flush.min_events. The analysis is conducted in Add multiple beat.Clients #37657 (comment)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 16, 2024
@kcreddy kcreddy marked this pull request as ready for review April 16, 2024 14:47
@kcreddy kcreddy requested review from a team as code owners April 16, 2024 14:47
Copy link
Contributor

mergify bot commented Apr 16, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kcreddy? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@kcreddy kcreddy changed the title x-pack/filebeat/input/gcppubsub: Prevent GCP Pub/Sub input blockage by increasing default max_outstanding_messages x-pack/filebeat/input/gcppubsub: Prevent input blockage by increasing default max_outstanding_messages Apr 16, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 16, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 117 min 43 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kcreddy kcreddy added the Team:Security-Service Integrations Security Service Integrations Team label Apr 16, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 16, 2024
@kcreddy kcreddy added the Team:Elastic-Agent Label for the Agent team label Apr 16, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@kcreddy kcreddy merged commit b84523d into elastic:main Apr 16, 2024
22 of 26 checks passed
@kcreddy kcreddy deleted the gcp-pubsub-defaults branch April 17, 2024 05:49
@kcreddy kcreddy mentioned this pull request Apr 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Filebeat Filebeat Team:Elastic-Agent Label for the Agent team Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants