Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12](backport #39455) x-pack/filebeat/input/internal/httplog: improve req/resp logging #39477

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Proposed commit message

Attempt to log the request and response bodies and other details even when copying the body has been reported to have failed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • Backporting because this is a visibility hole in support case.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #39455 done by [Mergify](https://mergify.com).

)

Attempt to log the request and response bodies and other details even
when copying the body has been reported to have failed.

(cherry picked from commit 3efb1e8)

# Conflicts:
#	x-pack/filebeat/input/internal/httplog/roundtripper.go
@mergify mergify bot added the backport label May 9, 2024
@mergify mergify bot requested a review from a team as a code owner May 9, 2024 00:11
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label May 9, 2024
@mergify mergify bot assigned efd6 May 9, 2024
Copy link
Contributor Author

mergify bot commented May 9, 2024

Cherry-pick of 3efb1e8 has failed:

On branch mergify/bp/8.12/pr-39455
Your branch is up to date with 'origin/8.12'.

You are currently cherry-picking commit 3efb1e8612.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/filebeat/input/internal/httplog/roundtripper.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 9, 2024
@botelastic
Copy link

botelastic bot commented May 9, 2024

This pull request doesn't have a Team:<team> label.

@efd6 efd6 force-pushed the mergify/bp/8.12/pr-39455 branch from 4705770 to d6cdf29 Compare May 9, 2024 00:26
@efd6
Copy link
Contributor

efd6 commented May 9, 2024

No longer a target.

@efd6 efd6 closed this May 9, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 9, 2024

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 25 min 0 sec

Pipeline error 1

This error is likely related to the pipeline itself. Click here
and then you will see the error (either incorrect syntax or an invalid configuration).

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify mergify bot deleted the mergify/bp/8.12/pr-39455 branch May 9, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants