-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] improve monitor state loader failure attempts #39621
[Heartbeat] improve monitor state loader failure attempts #39621
Conversation
d280533
to
6020314
Compare
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
39324dc
to
9cdb0bb
Compare
Hey @vigneshshanmugam , Is this ready for review? I can confirm that the failures bubbled up by CI are reproducible and don't exist e.g. on the regular runs on main https://buildkite.com/elastic/heartbeat/builds/5135
which I suppose is the reason why you tried adding an explicit timeout in the Buildkite steps. |
@dliappis Thanks for the link on the main branch, there was a bug in the code that caused the timeouts and made me think increasing would help. Should be fixed in the next run 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (all CI is green, no changes related to ingest-eng-prod owned codebase)
* [Heartbeat] improve state loader failure logs * try increasing timeouts * exit when there is no error * add state loader id (cherry picked from commit d5bfebb)
…39729) * [Heartbeat] improve state loader failure logs * try increasing timeouts * exit when there is no error * add state loader id (cherry picked from commit d5bfebb) Co-authored-by: Vignesh Shanmugam <[email protected]>
Description
PR addresses couple of things on the state loader
How to test this PR locally