Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Fix check-docs failing due to use of StartUpInfo instead of ConnInfo #39885

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 12, 2024

Fixes the failure in https://github.com/elastic/beats/actions/runs/9488427065/job/26147333159?pr=39832

mage check
>> fmt - go-licenser: Adding missing headers
>> fmt - goimports: Formatting Go code
>> Building elastic-agent.yml for linux/amd64
>> Building elastic-agent.reference.yml for linux/amd64
>> Building elastic-agent.docker.yml for linux/amd64
>> Buildspec from spec/*.yml to pkg/agent/program/supported.go
>> BuildPGP from GPG-KEY-elasticsearch to pkg/release/pgp.go
>> BuildFleetCfg _meta/elastic-agent.fleet.yml to pkg/agent/application/configuration_embed.go
go: downloading github.com/otiai10/copy v1.2.0
go: downloading github.com/kardianos/service v1.2.1-0.20210728001519-a323c3813bc7
go: downloading github.com/hectane/go-acl v0.0.0-20190604041725-da78bae5fc95
go: downloading github.com/gorilla/mux v1.7.3
go: downloading github.com/antlr/antlr4 v0.0.0-20200820155224-be881fa6b91d
go: downloading github.com/oklog/ulid v1.3.1
>> check: Checking source code for common problems
# github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/agent/operation/tests/scripts/serviceable-1.0-darwin-x86_64
Error: vet: pkg/agent/operation/tests/scripts/serviceable-1.0-darwin-x86_64/main.go:105:33: undefined: proto.StartUpInfo
Error: failed running go vet, please fix the issues reported: running "go vet ./..." failed with exit code 1
make[1]: *** [../../dev-tools/make/mage.mk:21: check] Error 1
make[1]: Leaving directory '/home/runner/work/beats/beats/x-pack/elastic-agent'
make: *** [Makefile:97: check] Error 1

@cmacknz cmacknz added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 12, 2024
@cmacknz cmacknz self-assigned this Jun 12, 2024
@cmacknz cmacknz requested a review from a team as a code owner June 12, 2024 20:21
@cmacknz cmacknz requested review from michalpristas and blakerouse and removed request for a team June 12, 2024 20:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 12, 2024
@cmacknz cmacknz requested a review from belimawr June 13, 2024 17:25
@jlind23 jlind23 enabled auto-merge (squash) June 17, 2024 12:02
@jlind23 jlind23 merged commit df1a0d7 into elastic:7.17 Jun 17, 2024
5 of 9 checks passed
@cmacknz cmacknz deleted the fix-elastic-agent-mage-check branch June 17, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants