Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Fix Kubernetes module metricbeat Go integration tests #39928

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 17, 2024

Running MODULE=kubernetes mage goIntegTest fails with a silent error, because the -v option was not passed to mage. Fixes this everywhere.

Additionally also fixes the root of the test failure, which is the Kind Kubernetes version being too new for the batch/v1beat apiVersion to exist anymore. Update the CronJob tests to batch/v1 instead as was done in 644d026 on main some time ago.

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 17, 2024
@cmacknz cmacknz self-assigned this Jun 17, 2024
@cmacknz cmacknz requested review from a team as code owners June 17, 2024 16:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 17, 2024
Copy link
Contributor

mergify bot commented Jun 17, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-kubernetes-integration-tests upstream/fix-kubernetes-integration-tests
git merge upstream/7.17
git push upstream fix-kubernetes-integration-tests

@pierrehilbert
Copy link
Collaborator

Thanks for taking care of this.

@cmacknz cmacknz merged commit 666c446 into elastic:7.17 Jun 17, 2024
104 checks passed
@cmacknz cmacknz deleted the fix-kubernetes-integration-tests branch June 17, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants