-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osquerybeat: Disable allow_unsafe osquery configuration #40130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksmaus
added
bug
backport-skip
Skip notification from the automated backport with mergify
labels
Jul 5, 2024
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 5, 2024
aleksmaus
added
the
Team:Security-Deployment and Devices
Deployment and Devices Team in Security Solution
label
Jul 5, 2024
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 5, 2024
pkoutsovasilis
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! nit: an entry to the changelog to capture that this change happened
Thanks Aleks! |
aleksmaus
added
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.15
Automated backport to the 8.15 branch with mergify
and removed
backport-skip
Skip notification from the automated backport with mergify
labels
Oct 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Osquerybeat: Disable allow_unsafe osquery configuration * Make linter happier * Added changelog * Make linter happier (cherry picked from commit fec980b)
6 tasks
aleksmaus
added
the
backport-7.17
Automated backport to the 7.17 branch with mergify
label
Oct 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Osquerybeat: Disable allow_unsafe osquery configuration * Make linter happier * Added changelog * Make linter happier (cherry picked from commit fec980b)
6 tasks
aleksmaus
added a commit
that referenced
this pull request
Oct 15, 2024
…figuration (#41239) * Osquerybeat: Disable allow_unsafe osquery configuration (#40130) * Osquerybeat: Disable allow_unsafe osquery configuration * Make linter happier * Added changelog * Make linter happier (cherry picked from commit fec980b) * Fix CHANGELOG.next.asciidoc --------- Co-authored-by: Aleksandr Maus <[email protected]>
aleksmaus
added a commit
that referenced
this pull request
Oct 15, 2024
…figuration (#41238) * Osquerybeat: Disable allow_unsafe osquery configuration (#40130) * Osquerybeat: Disable allow_unsafe osquery configuration * Make linter happier * Added changelog * Make linter happier (cherry picked from commit fec980b) * Fix CHANGELOG.next.asciidoc --------- Co-authored-by: Aleksandr Maus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7.17
Automated backport to the 7.17 branch with mergify
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.15
Automated backport to the 8.15 branch with mergify
bug
Team:Security-Deployment and Devices
Deployment and Devices Team in Security Solution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Osquerybeat: Disable
allow_unsafe
osquery configurationThe
allow_unsafe
flag was used for windows only since Oct 21, 2021.This addresses the issue reported in:
https://github.com/elastic/security/issues/2194
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
If any of the existing users used their custom extensions since 2021 without proper permissions set (the osquerybeat was careful to preserve modifications to the autoload file in order to allow these use cases)
https://osquery.readthedocs.io/en/stable/deployment/extensions/#extensions-binary-permissions
then these extensions will fail to load.
How to test this PR locally
Install the Agent with osquery manager integration in the policy. Make sure the extension loads.
Related issues