Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SQS metrics statistic method #40207

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 11, 2024

Proposed commit message

This PR is to fix statistic method applied to diff metrics in SQS metricset from aws module. This change has been done in elastic/integrations#8521 but didn't make it in Beats.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

It will not, because rename processor renamed all the fields from sqs metricset already. Users need to pay attention to the documentation change on the field description. But dashboards will not be broken.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner July 11, 2024 23:44
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 11, 2024
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 11, 2024
Copy link
Contributor

mergify bot commented Jul 11, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jul 11, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b sqs_metrics_stats upstream/sqs_metrics_stats
git merge upstream/main
git push upstream sqs_metrics_stats

@kaiyan-sheng kaiyan-sheng added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Jul 12, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 12, 2024
@kaiyan-sheng kaiyan-sheng added backport-v8.14.0 Automated backport with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Jul 12, 2024
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaiyan-sheng kaiyan-sheng merged commit 918edab into elastic:main Jul 24, 2024
28 checks passed
@kaiyan-sheng kaiyan-sheng deleted the sqs_metrics_stats branch July 24, 2024 16:28
mergify bot pushed a commit that referenced this pull request Jul 24, 2024
* Change SQS metrics statistic method

* add doc change and changelog

(cherry picked from commit 918edab)

# Conflicts:
#	x-pack/metricbeat/module/aws/fields.go
mergify bot pushed a commit that referenced this pull request Jul 24, 2024
* Change SQS metrics statistic method

* add doc change and changelog

(cherry picked from commit 918edab)
mergify bot pushed a commit that referenced this pull request Jul 24, 2024
* Change SQS metrics statistic method

* add doc change and changelog

(cherry picked from commit 918edab)
kaiyan-sheng added a commit that referenced this pull request Jul 24, 2024
* Change SQS metrics statistic method (#40207)

* Change SQS metrics statistic method

* add doc change and changelog

(cherry picked from commit 918edab)

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: kaiyan-sheng <[email protected]>
kaiyan-sheng added a commit that referenced this pull request Jul 24, 2024
* Change SQS metrics statistic method (#40207)

* Change SQS metrics statistic method

* add doc change and changelog

(cherry picked from commit 918edab)

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: kaiyan-sheng <[email protected]>
kaiyan-sheng added a commit that referenced this pull request Jul 24, 2024
* Change SQS metrics statistic method (#40207)

* Change SQS metrics statistic method

* add doc change and changelog

(cherry picked from commit 918edab)


Co-authored-by: kaiyan-sheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-v8.14.0 Automated backport with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants