Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat: add journey.duration mapping to synthetics event #40230

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Jul 12, 2024

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@vigneshshanmugam vigneshshanmugam requested a review from a team as a code owner July 12, 2024 21:05
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 12, 2024
@vigneshshanmugam vigneshshanmugam added Team:obs-ds-hosted-services Label for the Observability Hosted Services team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 12, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

Copy link
Contributor

mergify bot commented Jul 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @vigneshshanmugam? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@vigneshshanmugam vigneshshanmugam added the backport-skip Skip notification from the automated backport with mergify label Jul 12, 2024
Copy link
Collaborator

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam enabled auto-merge (squash) July 15, 2024 15:59
@vigneshshanmugam vigneshshanmugam merged commit 0be3e03 into elastic:main Jul 15, 2024
25 checks passed
@vigneshshanmugam vigneshshanmugam deleted the add-journey-field branch July 15, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants