-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PeriodicReportingFetchV2Error to fetch metrics multiple times #40251
Merged
pierrehilbert
merged 12 commits into
elastic:main
from
zmoog:zmoog/aws-metrics-flacky-tests
Jul 17, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
45fb23a
Retry fetching CloudWatch metrics a few times
zmoog 7afca5d
fix wrong import
zmoog cbf4312
Fix events
zmoog 3b7c381
Retry 5 times every 60s
zmoog 5b39dc1
Switch to PeriodicReportingFetchV2Error
zmoog 6ba87cb
Fix linter complaints
zmoog 27e2d7a
Remove unused code
zmoog 374cfc4
Remove unused code
zmoog 8fab1db
Address linter complaints
zmoog 4a06f1a
Address linter complaints
zmoog eb285fc
Improve function docs
zmoog 82fafee
Cleanup
zmoog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning on replacing ReportingfetchV2Error with PeriodicReportingFetchV2Error in other metricsets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to focus this PR on removing the flakiness from the test suite so that other teams can continue with their tasks.
Do you know of other tests that need more than one call to
Fetch()
to succeed due to latency or something similar?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if this solution proves effective, we can adopt it for more tests that need more than one fetch.