Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #40258) [bug][filestream] - Fix filebeat GC cleanup bug #40277

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[8.15](backport #40258) [bug][filestream] - Fix filebeat GC cleanup bug #40277

merged 2 commits into from
Jul 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 17, 2024 •
edited by zube bot
Loading

Type

  • bugfix

Proposed commit message

From #40178,

Default value for clean_inactive should be 0 (disabled) as explained in the filebeat.reference.yml (no default value indicated in the documentation), but registry entries are removed after 30 min of inactivity.

Fix this behaviour by adding a check to disable gcClean if ttl == -1

  • default clean_interval is changed to -1
  • Current behaviour remains unchanged
    • i.e. clean_inactive: 0 will clean states right after the file is closed

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

  • Registries are persisted forever if clean_inactive: -1

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #40258 done by [Mergify](https://mergify.com).

@VihasMakwana @mergify
[bug][filestream] - Fix filebeat GC cleanup bug (#40258)
d77d110 
* chore: initial commit

* chore: remove default 30mins

* fix: set -1 for default

* fix: typo

* fix: remove validator

* fix: typo

* chore: update reference.yml

* chore: add changelog

* fix: update reference.yml

* fix: address review comments

* fix: typo

(cherry picked from commit 1ca6e2f)
@mergify mergify bot requested a review from a team as a code owner July 17, 2024 13:34
@mergify mergify bot added the backport label Jul 17, 2024
@mergify mergify bot requested review from AndersonQ and rdner and removed request for a team July 17, 2024 13:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 17, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2024
cmacknz
cmacknz reviewed Jul 17, 2024
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@VihasMakwana VihasMakwana merged commit 3a9b0f0 into 8.15 Jul 18, 2024
27 checks passed
@VihasMakwana VihasMakwana deleted the mergify/bp/8.15/pr-40258 branch July 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz left review comments

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@pierrehilbert pierrehilbert pierrehilbert approved these changes

Assignees

@VihasMakwana VihasMakwana

Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elasticmachine @pierrehilbert @cmacknz @VihasMakwana