-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.15](backport #40429) [vSphere][host] Add support for new metrics in host metricset #40697
Conversation
* [vSphere][host] Data collection and Fields mappings * add changelog entry * update github.com/vmware/govmomi version * update go.sum * make check for beats * golint-ci * update the field mappings * mage update * add more UTs * metricbeat: mage update * Resolve review comments * Minor changes - Update interval * add vm and datastore names with count per host * fix and update mapping methods * remove fmt.Errorf (cherry picked from commit e09627f)
This pull request doesn't have a |
/test |
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (i didn't read the changes, assuming this is a clean backport of an already reviewed change)
Retrigerring it for the 3rd time. |
/test |
Description
Here are the following metrics to be added for the host data stream in the vSphere metricbeat module. Here we added a new performance API to get more detailed information from the vSphere.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
This is an automatic backport of pull request #40429 done by [Mergify](https://mergify.com).