Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #40429) [vSphere][host] Add support for new metrics in host metricset #40697

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2024

Description

Here are the following metrics to be added for the host data stream in the vSphere metricbeat module. Here we added a new performance API to get more detailed information from the vSphere.

Metrics Type Metrics API Field Mappings
Host Disk Performance      
  disk.deviceLatency.average (ms) Performance disk.devicelatency.average.ms
  disk.maxTotalLatency.latest (ms) Performance disk.latency.total.ms
  disk.usage.average (KBps) Performance disk.total.bytes
  disk.read.average (KBps) Performance disk.read.bytes
  disk.write.average (KBps) Performance disk.write.bytes
  disk.capacity.usage.average (KB) Performance disk.capacity.usage.bytes
       
Host uptime/status      
  host.Summary.OverallStatus Summary status
  host.Summary.QuickStats.Uptime Summary uptime
  host.Datastore Extra datastore.names
      datastore.count
  host.Vm Extra vm.names
      vm.count
       
Host Network Stats host.Netowork Extra network.names
      network.count
  net.transmitted.average (KBps) Performance network.bandwidth.transmitted.bytes
  net.received.average (KBps) Performance network.bandwidth.received.bytes
  net.usage.average (KBps) Performance network.bandwidth.total.bytes
  net.packetsTx.summation (num) Performance network.packets.transmitted.count
  net.packetsRx.summation (num) Performance network.packets.received.count
  net.errorsRx.summation (num) Performance network.packets.errors.received.count
  net.errorsTx.summation (num) Performance network.packets.errors.transmitted.count
      network.packets.errors.total.count
  net.multicastTx.summation (num) Performance network.packets.multicast.transmitted.count
  net.multicastRx.summation (num) Performance network.packets.multicast.received.count
      network.packets.multicast.total.count
  net.droppedTx.summation (num) Performance network.packets.dropped.transmitted.count
  net.droppedRx.summation (num) Performance network.packets.dropped.received.count
      network.packets.dropped.total.count

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues


This is an automatic backport of pull request #40429 done by [Mergify](https://mergify.com).

* [vSphere][host] Data collection and Fields mappings

* add changelog entry

* update github.com/vmware/govmomi version

* update go.sum

* make check for beats

* golint-ci

* update the field mappings

* mage update

* add more UTs

* metricbeat: mage update

* Resolve review comments

* Minor changes
- Update interval

* add vm and datastore names with count per host

* fix and update mapping methods

* remove fmt.Errorf

(cherry picked from commit e09627f)
@mergify mergify bot requested review from a team as code owners September 5, 2024 16:27
@mergify mergify bot added the backport label Sep 5, 2024
@mergify mergify bot requested review from rdner and leehinman and removed request for a team September 5, 2024 16:27
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 5, 2024
@botelastic
Copy link

botelastic bot commented Sep 5, 2024

This pull request doesn't have a Team:<team> label.

@ishleenk17
Copy link
Contributor

/test

Copy link
Contributor Author

mergify bot commented Sep 5, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40429 upstream/mergify/bp/8.15/pr-40429
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40429

@lalit-satapathy lalit-satapathy marked this pull request as draft September 6, 2024 09:02
@rdner rdner removed their request for review September 10, 2024 07:49
@ishleenk17 ishleenk17 marked this pull request as ready for review September 13, 2024 04:42
@ishleenk17
Copy link
Contributor

/test

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (i didn't read the changes, assuming this is a clean backport of an already reviewed change)

@ishleenk17
Copy link
Contributor

ishleenk17 commented Sep 13, 2024

Retrigerring it for the 3rd time.

@ishleenk17
Copy link
Contributor

/test

@ishleenk17 ishleenk17 merged commit 19ab356 into 8.15 Sep 13, 2024
123 checks passed
@ishleenk17 ishleenk17 deleted the mergify/bp/8.15/pr-40429 branch September 13, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants