Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #40751) libbeat/processors/replace: fix zero string replacement validation #40801

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[8.x](backport #40751) libbeat/processors/replace: fix zero string replacement validation #40801

merged 2 commits into from
Sep 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 12, 2024

Proposed commit message

The change in #40047 breaks the use of the replace processor to do s/<pattern>// replacement. So make the validation on absence, not zero state.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #40751 done by [Mergify](https://mergify.com).

@efd6 @mergify
libbeat/processors/replace: fix zero string replacement validation (#…
ce24b46 
…40751)

The change in #40047 breaks the use of the replace processor to do
s/<pattern>// replacement. So make the validation on absence, not zero state.

(cherry picked from commit a45a3ac)
@mergify mergify bot requested a review from a team as a code owner September 12, 2024 21:26
@mergify mergify bot added the backport label Sep 12, 2024
@mergify mergify bot requested review from rdner and VihasMakwana and removed request for a team September 12, 2024 21:26
@mergify mergify bot assigned efd6 Sep 12, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2024
@botelastic
Copy link

botelastic bot commented Sep 12, 2024

This pull request doesn't have a Team:<team> label.

efd6
efd6 reviewed Sep 12, 2024
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented Sep 12, 2024

/test

@efd6 efd6 mentioned this pull request Sep 13, 2024
Closed
6 tasks
@efd6 efd6 merged commit 3103a8a into 8.x Sep 13, 2024
124 checks passed
@efd6 efd6 deleted the mergify/bp/8.x/pr-40751 branch September 13, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efd6