Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add output kafka support for zstd #40880

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

gwy1995
Copy link

@gwy1995 gwy1995 commented Sep 18, 2024

Proposed commit message

add output kafka support for zstd

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@gwy1995 gwy1995 requested review from a team as code owners September 18, 2024 10:11
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 18, 2024
Copy link

cla-checker-service bot commented Sep 18, 2024

❌ Author of the following commits did not sign a Contributor Agreement:
e9d618e, fce6f18, 0b8ab87, 2e7e563, 6424318, 543a348, f055b75, 7b1019f, , 9f91ab2, 3f9e577, ca805d9, 898c4bb, 057edee

Please, read and sign the above mentioned agreement if you want to contribute to this project

Copy link
Contributor

mergify bot commented Sep 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gwy1995? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 18, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 18, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 18, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from faec and leehinman and removed request for khushijain21 and VihasMakwana September 18, 2024 11:39
@pierrehilbert
Copy link
Collaborator

Hello @gwy1995
Thanks for your contribution.
Could you please sign our CLA?

@gwy1995
Copy link
Author

gwy1995 commented Sep 19, 2024

Hello @gwy1995 Thanks for your contribution. Could you please sign our CLA?

I have signed it for three times , but it still shows as unsigned in this issue. What should I do ?

@pierrehilbert
Copy link
Collaborator

Did you sign it with the same email than your github account?

@gwy1995
Copy link
Author

gwy1995 commented Sep 20, 2024

Did you sign it with the same email than your github account?

yes, I have sign it today and yesterday for more than three times.

@faec
Copy link
Contributor

faec commented Sep 20, 2024

Hi @gwy1995, we can try figuring out where the CLA checker is having trouble, but another issue I notice is that you removed Elastic's sarama fork and replaced it with an older (downgraded) upstream version. (See the readme in the fork for details.) The fork includes fixes for serious issues, so any changes to the sarama version should either update the fork's base version, or update to a mainline version that includes the fixes we need.

@gwy1995
Copy link
Author

gwy1995 commented Sep 23, 2024

Hi @gwy1995, we can try figuring out where the CLA checker is having trouble, but another issue I notice is that you removed Elastic's sarama fork and replaced it with an older (downgraded) upstream version. (See the readme in the fork for details.) The fork includes fixes for serious issues, so any changes to the sarama version should either update the fork's base version, or update to a mainline version that includes the fixes we need.

Thanks for reminding me of this. I have rolled back the sarama version.
I found that the elastic version of sarama has merged the changes required by zstd, so just add one line of configuration. I wrote the details in the comments.Please take another look

@leehinman
Copy link
Contributor

looks good. Any chance you could add a test case to

func TestKafkaPublish(t *testing.T) {
?

@gwy1995
Copy link
Author

gwy1995 commented Sep 24, 2024

looks good. Any chance you could add a test case to

func TestKafkaPublish(t *testing.T) {

?

I add a test case. But I don't know why it didn't pass CI. I have tested it in the local environment.

@pierrehilbert
Copy link
Collaborator

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants