Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: drop custom sys package and use stdlib x/sys #40984

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

kruskall
Copy link
Member

Proposed commit message

drop custom fork of x/sys and use upstream package
regenerate notice

copy over custom methods

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

drop custom fork of x/sys and use upstream package
regenerate notice

copy over custom methods
@kruskall kruskall requested review from a team as code owners September 25, 2024 08:22
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 25, 2024
Copy link
Contributor

mergify bot commented Sep 25, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 25, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 25, 2024
@pierrehilbert pierrehilbert added the Team:Security-Windows Platform Windows Platform Team in Security Solution label Sep 26, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 26, 2024
@kruskall kruskall merged commit adbddfe into elastic:main Sep 27, 2024
182 checks passed
@kruskall kruskall deleted the feat/drop-custom-sys branch September 27, 2024 01:04
mergify bot pushed a commit that referenced this pull request Sep 27, 2024
* feat: drop custom sys package and use stdlib x/sys

drop custom fork of x/sys and use upstream package
regenerate notice

copy over custom methods

* lint: fix linting issues

(cherry picked from commit adbddfe)
pierrehilbert pushed a commit that referenced this pull request Sep 27, 2024
* feat: drop custom sys package and use stdlib x/sys

drop custom fork of x/sys and use upstream package
regenerate notice

copy over custom methods

* lint: fix linting issues

(cherry picked from commit adbddfe)

Co-authored-by: kruskall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants