Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packetbeat/module: fix upload of bundled ingest pipelines on Windows #41110

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 4, 2024

Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Packetbeat bugfix backport-8.15 Automated backport to the 8.15 branch with mergify labels Oct 4, 2024
@efd6 efd6 self-assigned this Oct 4, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 4, 2024
Copy link
Contributor

mergify bot commented Oct 4, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 4, 2024
@efd6 efd6 added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Oct 4, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 4, 2024
Detection of data stream identity was using os.PathSeparator which will
not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives
@efd6 efd6 marked this pull request as ready for review October 4, 2024 03:29
@efd6 efd6 requested a review from a team as a code owner October 4, 2024 03:29
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@efd6 efd6 enabled auto-merge (squash) October 4, 2024 05:55
@efd6 efd6 merged commit f55bd8d into elastic:main Oct 4, 2024
28 of 30 checks passed
@nicholasberlin
Copy link
Contributor

Thanks for handling this.

mergify bot pushed a commit that referenced this pull request Oct 4, 2024
…41110)

Detection of data stream identity was using os.PathSeparator which will
not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives

(cherry picked from commit f55bd8d)
mergify bot pushed a commit that referenced this pull request Oct 4, 2024
…41110)

Detection of data stream identity was using os.PathSeparator which will
not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives

(cherry picked from commit f55bd8d)
efd6 added a commit that referenced this pull request Oct 4, 2024
…41110) (#41116)

Detection of data stream identity was using os.PathSeparator which will
not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives

(cherry picked from commit f55bd8d)

Co-authored-by: Dan Kortschak <[email protected]>
efd6 added a commit that referenced this pull request Oct 4, 2024
…41110) (#41115)

Detection of data stream identity was using os.PathSeparator which will
not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives

(cherry picked from commit f55bd8d)

Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify bugfix Packetbeat Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants