Avoid unneeded runner restarts when using config reloading #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced by elastic#7172, some inputs/modules may modify the passed configuration, this results on a effective change on the hash of the config. Before this change, the reload process was taking a running config as a not running config. Resulting on a stop/start after the first run. Example (with some added debugging): First run (add 1 config): ``` 2018-06-01T02:08:20.184+0200 DEBUG [autodiscover] cfgfile/list.go:53 Starting reload procedure, current runners: 0 2018-06-01T02:08:20.185+0200 INFO cfgfile/list.go:143 map[type:docker containers:map[ids:[56322b70c8a3712494e559381c7b8a6ce62a6495e33630628e6624b75b5a7505]]] 2018-06-01T02:08:20.185+0200 INFO cfgfile/list.go:144 Hash: %!s(uint64=12172188027786936243) 2018-06-01T02:08:20.185+0200 DEBUG [autodiscover] cfgfile/list.go:71 Start list: 1, Stop list: 0 ``` Second run (add another config, the first one gets restarted): ``` 2018-06-01T02:08:20.185+0200 DEBUG [autodiscover] cfgfile/list.go:53 Starting reload procedure, current runners: 1 2018-06-01T02:08:20.185+0200 INFO cfgfile/list.go:143 map[paths:[/var/lib/docker/containers/56322b70c8a3712494e559381c7b8a6ce62a6495e33630628e6624b75b5a7505/*.log] docker-json:map[stream:all partial:true] type:docker containers:map[ids:[56322b70c8a3712494e559381c7b8a6ce62a6495e33630628e6624b75b5a7505]]] 2018-06-01T02:08:20.185+0200 INFO cfgfile/list.go:144 Hash: %!s(uint64=12741034856879725532) 2018-06-01T02:08:20.185+0200 INFO cfgfile/list.go:143 map[type:docker containers:map[ids:[a626e25679abd2b9af161277f1beee96c1bba6b9412771d17da7ebfacca640a7]]] 2018-06-01T02:08:20.185+0200 INFO cfgfile/list.go:144 Hash: %!s(uint64=7080456881540055745) 2018-06-01T02:08:20.185+0200 DEBUG [autodiscover] cfgfile/list.go:71 Start list: 2, Stop list: 1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #7172, some inputs/modules may modify the passed
configuration, this results on a effective change on the hash of
the config. Before this change, the reload process was taking a running
config as a not running config. Resulting on a stop/start after the
first run.
Failing example, before this change:
First run (add 1 config):
Second run (add another config, the first one gets restarted):