Cherry-pick #8216 to 6.x: Add a wait baseline when looking up registry values #8239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the nature of VMs and disk, writing or reading a file can be out of sync. Instead of only sleeping only the windows case we sleep on every tested platform before asserting the content of the registry. closes elastic#8102 (cherry picked from commit ca78d74)
exekias
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8216 to 6.x branch. Original message:
With the nature of VMs and disk, writing or reading a file can be out of sync.
Instead of only sleeping only the windows case we sleep on every tested
platform before asserting the content of the registry.
closes #8102
Notes: I am not a fan of adding sleeps call to existing code, but we are in the processing of writing a new registry. The new system offer better way to look for changes in the form of an oplog. So we could refactor the test to check for opload changes instead of the active registry.