Set packaging defaults for Jenkins #8542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control the defaults for Jenkins in our repo, but allow them to be overridden by Jenkins parameters.
|
This will add back the |
|
Started a package test: https://beats-ci.elastic.co/job/elastic+beats+pull-request+package/4/ |
ruflin
approved these changes
Oct 3, 2018
| @@ -16,4 +16,10 @@ cleanup() { | |||
| } | |||
| trap cleanup EXIT | |||
|
|
|||
| # This controls the defaults used the Jenkins package job. They can be | |||
| # overridden by setting them in the environement prior to running this script. | |||
| export BEAT_VERSION_QUALIFIER="${VERSION_QUALIFIER:-alpha1}" | |||
There was a problem hiding this comment.
So these values would be adjusted based on the branch?
There was a problem hiding this comment.
Yes, that would be the case. The alternative would be to put it in the JJB config in infra, but we want to get away from that model in order to have more control over our Jenkins jobs from our repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control the defaults for Jenkins in our repo, but allow them to be
overridden by Jenkins parameters.