allow/merge fields.yml overrides #9188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 21, 2018
graphaelli
force-pushed
the
fields-merge
branch
from
c5223d9
to
4abfab1
Compare
graphaelli
force-pushed
the
fields-merge
branch
from
4abfab1
to
cbceb4b
Compare
simitt
approved these changes
Nov 21, 2018
ruflin
reviewed
Nov 21, 2018
There was a problem hiding this comment.
Could we introduce perhaps a convention that fields which are defined as duplicates actually must have a flag like overwrite: true or something like this. Otherwise we can't tell the difference between accidential duplicates and duplicates which are there on purpose.
ruflin
requested changes
Nov 27, 2018
|
Thanks for the reviews. All feedback has been addressed and a merge with master + |
ruflin
approved these changes
Nov 27, 2018
|
Merging without waiting on Darwin to avoid being beaten by a merge conflict yet again. Rest of the Jenkins run is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of fields.ecs.yml fields that were application specific are now defined generically by libbeat.
This change introduces the ability to customize certain attributes of fields by those downstream. For example, APM sets the
countattribute (kibana "popularity") onerror.idand is unable to integratefields.ecs.ymland retain that without a change like this.Care was taken to forbid field type changes. That is a field can't be defined as a
keywordin one place and overridden tolongin another.Reviewers: Please consider whether all affected
fields.ymlconsumers are handled by these changes.