Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to disable docker cpu metrics collection per core #9194

Merged
merged 3 commits into from
Nov 23, 2018

Conversation

jsoriano
Copy link
Member

Docker CPU metrics collection per core can create loads of fields in hosts with lots of CPUs, and I am not sure if this is so useful. Add a flag to be able disable them by now on 6.6, and we can consider later to disable them by default on 7.0.

@jsoriano jsoriano added module review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. containers Related to containers use case labels Nov 21, 2018
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruflin
Copy link
Member

ruflin commented Nov 23, 2018

@jsoriano I resolved the changelog conflict.

@jsoriano
Copy link
Member Author

Issues added for flaky tests

@jsoriano jsoriano merged commit 52df22d into elastic:master Nov 23, 2018
@jsoriano jsoriano deleted the docker-disable-cpu-per-core branch November 23, 2018 13:47
jsoriano added a commit to jsoriano/beats that referenced this pull request Nov 23, 2018
@jsoriano jsoriano added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 23, 2018
jsoriano added a commit that referenced this pull request Nov 23, 2018
jsoriano added a commit that referenced this pull request Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case Metricbeat Metricbeat module review v6.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants