-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifying Poetry projects #1916
base: main
Are you sure you want to change the base?
Unifying Poetry projects #1916
Conversation
This pull request does not have a backport label. Could you fix it @oren-zohar? 🙏
|
❌ No tests were run ❌ |
pip3 install poetry | ||
cd security-policies | ||
poetry install | ||
pipx install poetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use pipx
in this workflow and pip3
in other workflows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For installing Python-based CLI tools (like poetry, black, flake8, etc.), it's recommended to use use pipx
. For installing Python packages to the environment, such as libraries used in your code (like numpy, pandas, requests, etc.), use pip
/pip3`. I will update the other workflows
.github/workflows/test-gcp-dm.yml
Outdated
env: | ||
STACK_VERSION: ${{ env.ELK_VERSION }} | ||
DEPLOYMENT_NAME: ${{env.GCP_DEPLOYMENT_NAME}} | ||
run: | | ||
poetry install | ||
poetry run python src/install_cspm_gcp_integration.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my mistake; the path is incorrect. It should now be tests/integrations_setup/install_cspm_gcp_integration.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oren-zohar Great work! Why didn't you remove pyproject.toml
in the tests
and security-policies
directories as well? The tests Dockerfile
needs fixing; otherwise, this will not work for K8s CI testing.
This pull request is now in conflicts. Could you fix it? 🙏
|
Summary of your changes
Related Issues
Checklist