Fix Create Environment agent version for Serverless #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @opauloh? 🙏
|
|
Thanks Paulo! I'll try to deploy an env from this brach to validate |
5 tasks
gurevichdmitry
approved these changes
Oct 7, 2024
|
@gurevichdmitry it seems I can't merge this PR even after it was approved, could you merge it? |
kubasobon
pushed a commit
to kubasobon/cloudbeat
that referenced
this pull request
Oct 29, 2024
fix: using the input version for serverless Co-authored-by: Dmitry Gurevich <[email protected]> Co-authored-by: eyalkraft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
This fixes #2546, by using the version inputted by the user in the Create Environment parameters instead of using the version from the
env.ELK_VERSION.While it is true that the version doesn't matter on Serverless in terms of Kibana and Elasticsearch, it does matter for deploying agents as the snapshots might be no longer available.