-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] 3rd Party EDR Compatibility - 17 #4042
Open
w0rk3r
wants to merge
2
commits into
main
Choose a base branch
from
3rd_compat_16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rk3r
added
Rule: Tuning
tweaking or tuning an existing rule
OS: Windows
windows related rules
Domain: Endpoint
backport: auto
labels
Aug 29, 2024
w0rk3r
requested review from
Mikaayenson,
Samirbous,
Aegrah,
shashank-elastic and
terrancedejesus
August 29, 2024 00:19
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
Aegrah
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if unit tests now pass after the fix.
rules/windows/privilege_escalation_unusual_parentchild_relationship.toml
Outdated
Show resolved
Hide resolved
Samirbous
approved these changes
Aug 29, 2024
terrancedejesus
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Endpoint
OS: Windows
windows related rules
Rule: Tuning
tweaking or tuning an existing rule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Summary
Adjusts to rules to introduce or improve compatibility and documentation with 3rd party data such as Sysmon, MDE, and S1.
EDR field compatibility matrix: https://docs.google.com/spreadsheets/d/1ZaRmSXIVYLO9AGXeZge3u0W938aGxbfd6Vha52Rs1_I/edit?usp=sharing
Blocker
To use SentinelOne cloud funnel data right now, we would need to min_stack the rules to 8.13, so we are going to hold off on merging these until 8.16 is released and support for 8.12 is dropped. The updated_date is set to the 8.16 public release date.