[Rule Tuning] Add timeline_title to rules with timeline IDs defined #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
added
Rule: Tuning
|
cc: @dcode |
brokensound77
commented
Nov 2, 2020
spong
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
related to failures from elastic/kibana/pull/82214
Summary
Failures in the latest rules merge to Kibana revealed that tests within the security app require a
timeline_titleto be defined when a rule has atimeline_iddefined (the API allows for either to be independently defined).This PR adds
timeline_titleto all applicable rules and adds tests to ensure this is done for all future rules.Once this merges, will update the existing Kibana PR.