Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logstash support #171

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Add Logstash support #171

merged 6 commits into from
Jul 7, 2023

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jul 3, 2023

This adds support for getting Logstash resources and running elastic/support-diagnostics with --type logstash-api from ECK 2.8.0.

Resolves #170.

@thbkrkr thbkrkr added the enhancement New feature or request label Jul 3, 2023
thbkrkr
thbkrkr commented Jul 3, 2023
View reviewed changes
internal/stackdiag.go Outdated Show resolved Hide resolved
pebrc
pebrc approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit 71ca17c into main Jul 7, 2023
1 check passed
@thbkrkr thbkrkr deleted the support-logstash branch August 4, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pebrc pebrc pebrc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Logstash
2 participants
@thbkrkr @pebrc