Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger builds when tags are pushed #202

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Nov 8, 2023

This commit updates the Buildkite pipeline configuration to trigger builds when tags are pushed.

@@ -20,7 +20,8 @@ spec:
name: eck-diagnostics
spec:
repository: elastic/eck-diagnostics
pipeline_file: ".buildkite/pipeline.yml"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it is the default location.

@@ -20,7 +20,8 @@ spec:
name: eck-diagnostics
spec:
repository: elastic/eck-diagnostics
pipeline_file: ".buildkite/pipeline.yml"
provider_settings:
build_tags: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set to false by default. I hesitated to explicitly recall the other values for which the default values suit us well:

    provider_settings:
        trigger_mode: "code"
        build_pull_requests: true
        build_branches: true
        build_tags: true

@thbkrkr thbkrkr requested a review from pebrc November 8, 2023 14:06
@thbkrkr thbkrkr enabled auto-merge (squash) November 8, 2023 14:06
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit 515b3ef into main Nov 8, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants