Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase elastic apm dependency version in Elastic.Apm.SerilogEnricher #61

Closed
gregkalapos opened this issue Mar 6, 2020 · 3 comments
Closed
Assignees

Comments

@gregkalapos
Copy link
Contributor

In order to fix #58 I opened elastic/apm-agent-dotnet#753 in the .NET APM Agent repo.

That'll fix the issue, but we also have to make sure that Elastic.Apm.SerilogEnricher forces users to use the latest agent, otherwise they'll run into the same bug.

So, once the next APM .NET Agent version is out which contains elastic/apm-agent-dotnet#753, we need to update Elastic.Apm.SerilogEnricher.csproj and make sure Elastic.Apm.SerilogEnricher depends on the version with the fix.

@gregkalapos gregkalapos self-assigned this Mar 6, 2020
@codebrain
Copy link
Contributor

Makes sense @gregkalapos , if you want to ping in here when it is ready I can handle the increment and publishing.

We have some releases in the pipeline for:

1.4.3 - https://github.com/elastic/ecs-dotnet/pulls?q=is%3Apr+is%3Aopen+label%3Av1.4.3
1.5.0 - https://github.com/elastic/ecs-dotnet/pulls?q=is%3Apr+is%3Aopen+label%3Av1.5.0

So will need to ensure this is coordinated properly.

@ffMathy
Copy link

ffMathy commented Mar 23, 2020

I guess it is ready now right?

@gregkalapos
Copy link
Contributor Author

Right, Elastic APM 1.4.0 is out which has the fix.
I opened #66.

codebrain pushed a commit that referenced this issue Mar 25, 2020
Fixes #58
Fixes #61

(cherry picked from commit 509c0e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants