Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EcsLayout - Use LogEventInfo.Logger instead of hardcoded DefaultLogger #67

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 30, 2020

Resolves #56

@codebrain
Copy link
Contributor

cla/check

@snakefoot
Copy link
Contributor Author

snakefoot commented Mar 31, 2020 via email

@snakefoot
Copy link
Contributor Author

@Mpdreamz Any chance of having this merged?

@snakefoot
Copy link
Contributor Author

@codebrain Is there something I can do, so this can be merged?

@Mpdreamz
Copy link
Member

Mpdreamz commented May 4, 2020

@snakefoot will look at it this week to get it in. Thank you for the PR, sorry for the radio silence!

@apmmachine
Copy link
Contributor

apmmachine commented May 8, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [v1v commented: Jenkins run the tests please]

  • Start Time: 2020-05-11T14:12:43.885+0000

  • Duration: 10 min 17 sec (617055)

  • Commit: ae47713

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 4
Total 29

@Mpdreamz
Copy link
Member

Mpdreamz commented May 8, 2020

Hopefully my merge build will spin on CI. Will merge it in if so and passes.

THanks again @snakefoot 👍

@snakefoot
Copy link
Contributor Author

@Mpdreamz All builds done by you or me says:

githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

@v1v
Copy link
Member

v1v commented May 11, 2020

Jenkins run the tests please

@snakefoot
Copy link
Contributor Author

@v1v Thank you! Can you also do the magic on #76 and #75 ?

@Mpdreamz Mpdreamz merged commit 3f5ae3f into elastic:master May 11, 2020
v1v added a commit to v1v/ecs-dotnet that referenced this pull request Jun 8, 2020
…utomation

* upstream/master: (28 commits)
  bump version to 1.5.1
  move to released assembly differ
  Expose Serialize(StringBuilder) overload (elastic#82)
  fix elastic#79 only inject layout renderer keys for APM if Elastic.Apm.NLog … (elastic#83)
  upgrade Bullseye from 3.0.0 to 3.3.0 (elastic#70)
  NLog EcsLayout - Added support for Log Origin (elastic#78)
  add benchmarks for simple serialization cases (elastic#81)
  update integration tests
  move to Elastic.Elasticsearch.Xunit
  NLog Ecs Layout event Enrichment (elastic#74)
  Microsoft.AspNetCore.Http.Abstractions ver. 2.1.0 has LTS (elastic#76)
  EcsLayout - Use LogEventInfo.Logger instead of hardcoded DefaultLogger (elastic#67)
  Added Beta Notice (elastic#65)
  Bump to 1.5.0
  Implement ECS schema 1.5 (elastic#60)
  Update branch name
  Bump to 1.4.4
  Increase Elastic.Apm dependency to 1.4.0 (elastic#66)
  Bump to 1.4.3
  Modify accessors to mark internal/private and to not expose outside of assembly.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use correct logger name
5 participants