Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Create ELF Fieldset - Stage 3 Proposal #1686

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[RFC] Create ELF Fieldset - Stage 3 Proposal #1686

wants to merge 6 commits into from

Conversation

peasead
Copy link
Contributor

@peasead peasead commented Dec 7, 2021

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@peasead peasead added the RFC label Dec 7, 2021
@peasead peasead self-assigned this Dec 7, 2021
Copy link

@devonakerr devonakerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peasead, concise update: LGTM

@ebeahan
Copy link
Member

ebeahan commented Dec 7, 2021

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@kgeller
Copy link
Contributor

kgeller commented Dec 8, 2021

@elasticmachine run elasticsearch-ci/docs

@ebeahan
Copy link
Member

ebeahan commented Dec 13, 2021

Stage 3 checklist:

  • Opened pull request for this candidate revising the existing candidate
  • Included multiple real world example source documents
  • Existing or newly raised questions and concerns are addressed
  • No objections from sponsor, ECS team, or subject matter experts

@github-actions
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC stale Stale issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants