Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Stage 2 for volume device #2260

Merged
merged 11 commits into from
Sep 11, 2023
Merged

[RFC] Stage 2 for volume device #2260

merged 11 commits into from
Sep 11, 2023

Conversation

Trinity2019
Copy link
Contributor

  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? N/A
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? N/A
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. Yes
  • Have you added an entry to the CHANGELOG.next.md? N/A

@Trinity2019 Trinity2019 requested a review from a team as a code owner August 27, 2023 05:48
@Trinity2019 Trinity2019 changed the title Volume device rfc2 [RFC] Stage 1 for volume device Aug 27, 2023
@Trinity2019 Trinity2019 changed the title [RFC] Stage 1 for volume device [RFC] Stage 2 for volume device Aug 27, 2023
@Trinity2019
Copy link
Contributor Author

@ricardoungureanu @stanek-michal could you review this rfc stage 2 pr?

@Trinity2019
Copy link
Contributor Author

@ebeahan Could you review and merge this PR? Thanks in advance!

ebeahan
ebeahan approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Set advancement date for stage 2.

@ebeahan ebeahan merged commit a5ff8f1 into elastic:main Sep 11, 2023
1 check passed
@ebeahan ebeahan mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoungureanu ricardoungureanu ricardoungureanu approved these changes

@intxgo intxgo intxgo approved these changes

@ebeahan ebeahan ebeahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trinity2019 @ebeahan @intxgo @ricardoungureanu