Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host.containerized and os.codename #294

Closed
wants to merge 1 commit into from

Conversation

andrewvc
Copy link

This came up in #75 and elastic/beats#9154.

These fields seem useful. I notice no other fields in ECS are boolean, so this may be a first.

This came up in elastic#75 and elastic/beats#9154.

These fields seem useful. I notice no other fields in ECS are boolean, so this may be a first.
@webmat
Copy link
Contributor

webmat commented Dec 21, 2018

Thanks @andrewvc!

Not exactly the same semantics, but check out the definition for the new field os.full, wrt OS code names: https://github.com/elastic/ecs#os. Would this work for your use case?

As for host.containerized, a few things:

  • I applaud you on your courage to introduce the first boolean! However you can only get that distinction if you actually make the field boolean, right now it's keyword ;-)
  • Out of curiosity, in this case you're using host to report information from the point of view of the containerized process, correct? Can you expand on the situation, and perhaps give an example event how you would envision this?
    • I wonder if the .containerized field shouldn't be elsewhere, like perhaps process.containerized or service.containerized.

@MikePaquette
Copy link
Contributor

@andrewvc @webmat at one point, we considered host.type: container as the way to capture this information. Would that work?

Other example values of host.type could be: { "hardware" , "virtual_machine" , "container" , "instance" , ... }

Now that we have the cloud.* fields, the current definition of host.type could be changed to reflect this if we think it would work.

@webmat
Copy link
Contributor

webmat commented Dec 21, 2018

Oh that could work too, indeed. You're right that the current host.type example (t2.medium) sounds redundant vs cloud.machine.type.

@andrewvc
Copy link
Author

andrewvc commented May 1, 2019

Is there still interest in this issue? CC @ppf2

@webmat
Copy link
Contributor

webmat commented May 1, 2019

We'll need to step back and have a broader discussion, for what happens here.

I could see some value in adding os.codename, although os already has a pretty good amount of fields. Not sure if adding codename in adition to name and full is all that useful.

As for host.containerized, we've discussed in other places that host was purely meant for a VM or a physical host. Not for a container. The container details belong in container. Do you know how host.containerized is being populated in Beats? I'd like to better understand the semantics.

The fix for what @ppf2 reported is actually a bugfix in Beats. If Beats populates these custom fields (at least custom for now), there should be a field definition added in libbeat/_meta/fields.common.yml.

@andrewvc
Copy link
Author

andrewvc commented May 1, 2019

@webmat I'm +1 for fixing this in beats as custom fields. I'm going to close this issue given that.

@andrewvc andrewvc closed this May 1, 2019
@ruflin
Copy link
Member

ruflin commented May 2, 2019

@webmat We should sync up offline around if host is also mean for containers and others. Not sure if we are on the same page here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants