fix: rely solely on configIdx changes to capture a TriggeredConfigChange

pkg/client/unit.go

@@ -325,40 +325,8 @@ func (u *Unit) updateState(
 
 	if u.configIdx != cfgIdx {
 		u.configIdx = cfgIdx
-		if !gproto.Equal(u.config.GetSource(), cfg.GetSource()) {
-			u.config = cfg
-			triggers |= TriggeredConfigChange
-		}
-	}
-
-	if u.config.GetRevision() != cfg.GetRevision() {
-		u.config = cfg
-		triggers |= TriggeredConfigChange
-	}
-
-	switch {
-	case u.config == cfg:
-		break
-	case u.config != nil && cfg == nil:
-		u.config = cfg
-		triggers |= TriggeredConfigChange
-	case u.config == nil && cfg != nil:
 		u.config = cfg
 		triggers |= TriggeredConfigChange
-	case u.config != nil && cfg != nil:
-		if len(u.config.Streams) != len(cfg.Streams) {
-			u.config = cfg
-			triggers |= TriggeredConfigChange
-			break
-		}
-
-		for idx, stream := range cfg.Streams {
-			if !gproto.Equal(stream, cfg.Streams[idx]) {
-				u.config = cfg
-				triggers |= TriggeredConfigChange
-				break
-			}
-		}
 	}
 
 	if !gproto.Equal(u.apm, expAPM) {

pkg/client/unit_test.go

@@ -38,9 +38,10 @@ func TestUnitUpdateWithSameMap(t *testing.T) {
 	_, err = gproto.Marshal(newUnit)
 	require.NoError(t, err)
 
-	// This should return TriggeredNothing, as the two underlying maps in `source` are the same
+	// This should return TriggeredConfigChange, as the configIdx has changed (this is our criteria)
+	// no matter if the actual map is the same
 	got := defaultTest.updateState(UnitStateHealthy, UnitLogLevelDebug, 0, nil, newUnit, 2, nil)
-	assert.Equal(t, TriggeredNothing, got)
+	assert.Equal(t, TriggeredConfigChange, got)
 }
 
 func TestUnitUpdateWithNewMap(t *testing.T) {