-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IsZero to CPU Totals, report value for monitoring #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
Something isn't working
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
v8.4.0
labels
Jul 6, 2022
fearful-symmetry
requested review from
faec and
leehinman
and removed request for
a team
July 6, 2022 18:02
cmacknz
reviewed
Jul 6, 2022
cmacknz
reviewed
Jul 6, 2022
Okay, tinkered with this a bit more. The logic that adds |
cmacknz
reviewed
Jul 7, 2022
cmacknz
reviewed
Jul 7, 2022
cmacknz
reviewed
Jul 7, 2022
|
cmacknz
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
v8.3.0
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes three issues:
CPUTotals
anIsZero
method, so we don't report{}
fields during certain eventsValue
field forGetSelf()
, which is used by beats self-monitoring, and apparently that value is used by theelastic_agent
dashboard.GetSelf()
persist across calls