Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert: Bundle elastic-agent.app for MacOS… #714 #1387

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Revert: Bundle elastic-agent.app for MacOS… #714 #1387

merged 2 commits into from
Sep 30, 2022

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Sep 30, 2022 •
edited by joshdover
Loading

Reverts #714

Reverting this PR as for issue raised here: #1298

Issue for followup work created here: #1386

@michalpristas michalpristas added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Sep 30, 2022
@michalpristas michalpristas requested a review from a team as a code owner September 30, 2022 09:02
@michalpristas michalpristas requested review from AndersonQ and michel-laterman and removed request for a team September 30, 2022 09:02
@michalpristas michalpristas mentioned this pull request Sep 30, 2022
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 30, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-30T09:34:25.103+0000

  • Duration: 40 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 4943
Skipped 17
Total 4960

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 30, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 97.297% (72/74) 👎 -0.036
Files 69.13% (159/230) 👍 1.334
Classes 69.163% (314/454) 👍 0.981
Methods 53.174% (888/1670) 👍 0.756
Lines 39.224% (9578/24419) 👍 0.493
Conditionals 100.0% (0/0) 💚

@michalpristas michalpristas merged commit e61c506 into elastic:8.5 Sep 30, 2022
aleksmaus added a commit to aleksmaus/elastic-agent that referenced this pull request Oct 2, 2022
@aleksmaus
Revert "Revert: Bundle elastic-agent.app for MacOS… elastic#714 (elas…
1cb6321 
…tic#1387)"

This reverts commit e61c506.
aleksmaus added a commit that referenced this pull request Oct 3, 2022
@aleksmaus
Fix: Agent failed to upgrade from 8.4.2 to 8.5.0 BC1 for MAC 12 agent…
38365ec 
… using agent binary. (#1392)

* Revert "Revert:  Bundle elastic-agent.app for MacOS… #714  (#1387)"

This reverts commit e61c506.

* Fix upgrade for Mac OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@aleksmaus aleksmaus Awaiting requested review from aleksmaus

Assignees

@michalpristas michalpristas

Labels
bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalpristas @elasticmachine