Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] MacOS 15 testing #5919

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[CI] MacOS 15 testing #5919

wants to merge 15 commits into from

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Nov 1, 2024 •
edited by rowlandgeoff
Loading

What does this PR do?

Adds MacOS 15 ARM tests unit tests for PRs and merge to release branches.
Makes MacOS 13 x86 tests run only on main and release branches

MacOS 14 is expected in a follow-up PR

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added enhancement New feature or request skip-changelog Team:Ingest-EngProd backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 1, 2024
@mergify mergify bot assigned pazone Nov 1, 2024
@pazone pazone marked this pull request as ready for review November 8, 2024 18:27
@pazone pazone requested a review from a team as a code owner November 8, 2024 18:27
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

rowlandgeoff
rowlandgeoff reviewed Nov 12, 2024
View reviewed changes
.buildkite/pipeline.yml
- group: "macOS tests"
key: "macos-unit-tests"
steps:
- label: "Unit tests - MacOS 15 ARM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: "Unit tests - MacOS 15 ARM"
- label: "Unit tests - macOS 15 ARM"

rowlandgeoff
rowlandgeoff reviewed Nov 12, 2024
View reviewed changes
.buildkite/pipeline.yml
retry:
manual:
allowed: true

# Runs only on main and release branches
- label: "Unit tests - MacOS 13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: "Unit tests - MacOS 13"
- label: "Unit tests - macOS 13"

rowlandgeoff
rowlandgeoff approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@rowlandgeoff rowlandgeoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just those couple of nit-picks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

Assignees

@pazone pazone

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement New feature or request skip-changelog Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pazone @rowlandgeoff