Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Buildkite integration tests: Run integration tests on ARM #5956

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[CI] Buildkite integration tests: Run integration tests on ARM #5956

merged 3 commits into from
Nov 11, 2024
+30 −106

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Nov 6, 2024 •
edited
Loading

What does this PR do?

Enhances the buildkite tests pipeline by ARM tests. It uses the prebuilt Ubuntu 24.04 ARM image
Runs integration test groups separately. Allows independent reruns.
Tested here: Example build.

Note: It doesn't replace current integration tests. The new buildkite pipeline is not triggered by GitHub events

Why is it important?

We have to test elastic agent on ARM architecture

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone requested review from a team as code owners November 6, 2024 15:30
@mergify mergify bot assigned pazone Nov 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 6, 2024
pchila
pchila approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rowlandgeoff
Copy link
Contributor

Where do we run the non-sudo tests?

@pazone
Copy link
Contributor Author

pazone commented Nov 7, 2024

Where do we run the non-sudo tests?

I can add return non-sudo tests back to the pipeline. I'd do that in a separate PR

rowlandgeoff
rowlandgeoff reviewed Nov 7, 2024
View reviewed changes
.buildkite/bk.integration.pipeline.yml Outdated
artifact_paths:
- build/**
agents:
provider: "gcp"
imageProject: elastic-images-qa
machineType: "n1-standard-8"
image: "family/platform-ingest-elastic-agent-ubuntu-2204"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like agent tests are currently running against 2404, not 2204

rowlandgeoff
rowlandgeoff reviewed Nov 7, 2024
View reviewed changes
.buildkite/bk.integration.pipeline.yml Outdated
@@ -38,115 +38,45 @@ steps:
- package-it
- integration-ess
steps:
- label: "Default"
key: stateful-ubuntu-default-sudo
- label: "x86:Group: {{matrix}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: more accurate to call this x64? Or x86-x64?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86_64. But now i think amd64 is more clear 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with x86_64, since I think we use that term more consistently in other places

@rowlandgeoff
Copy link
Contributor

Run the new pipeline on push to main.

Do you want to enable with this PR or a follow-up?

leehinman
leehinman approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@pazone pazone merged commit c01636e into main Nov 11, 2024
14 checks passed
@pazone pazone deleted the bk-tests_arm branch November 11, 2024 11:55
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
@pazone @mergify
[CI] Buildkite integration tests: Run integration tests on ARM (#5956)
d7f1ed4 
* [CI]Run Ubuntu x86 and ARM integration tests on buildkite

* Updated the new pipeline

* Applied review changes

(cherry picked from commit c01636e)

# Conflicts:
#	.buildkite/scripts/sudo-integration-tests.sh
@mergify mergify bot mentioned this pull request Nov 11, 2024
Open
7 tasks
swiatekm pushed a commit that referenced this pull request Nov 12, 2024
@pazone @swiatekm
[CI] Buildkite integration tests: Run integration tests on ARM (#5956)
6a27324 
* [CI]Run Ubuntu x86 and ARM integration tests on buildkite

* Updated the new pipeline

* Applied review changes

(cherry picked from commit c01636e)

# Conflicts:
#	.buildkite/scripts/sudo-integration-tests.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchila pchila pchila approved these changes

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

@leehinman leehinman leehinman approved these changes

@pkoutsovasilis pkoutsovasilis Awaiting requested review from pkoutsovasilis pkoutsovasilis is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@belimawr belimawr Awaiting requested review from belimawr

Assignees

@pazone pazone

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement New feature or request skip-changelog Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pazone @rowlandgeoff @leehinman @pchila