Merge branch 'master' into pr/544

elastic · Feb 21, 2020 · 4d73ff3 · 4d73ff3
2 parents 3e2b507 + df16bb9
commit 4d73ff3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## [17.1.1](https://github.com/elastic/elastic-charts/compare/v17.1.0...v17.1.1) (2020-02-21)
+
+
+### Bug Fixes
+
+* redux connect memo issue related to spec upserting ([#563](https://github.com/elastic/elastic-charts/issues/563)) ([f3a05f1](https://github.com/elastic/elastic-charts/commit/f3a05f1abe35d690e433a8ad9b6f5a999a7da7fe))
+
 # [17.1.0](https://github.com/elastic/elastic-charts/compare/v17.0.3...v17.1.0) (2020-02-12)
 
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@elastic/charts",
   "description": "Elastic-Charts data visualization library",
-  "version": "17.1.0",
+  "version": "17.1.1",
   "author": "Marco Vettorello <[email protected]>",
   "license": "Apache-2.0",
   "main": "dist/index.js",

diff --git a/src/state/spec_factory.ts b/src/state/spec_factory.ts
@@ -51,5 +51,12 @@ const mapDispatchToProps = (dispatch: Dispatch): DispatchProps =>
   );
 
 export function getConnect() {
-  return connect(null, mapDispatchToProps);
+  /**
+   * Redux assumes shallowEqual for all connected components
+   *
+   * This causes an issue where the specs are cleared and memoized spec components will never be
+   * rerendered and thus never re-upserted to the state. Setting pure to false solves this issue
+   * and doesn't cause traditional performance degradations.
+   */
+  return connect(null, mapDispatchToProps, null, { pure: false });
 }