Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flamegraph] tweening stopped (regression) #1540

Closed
2 of 3 tasks
monfera opened this issue Dec 29, 2021 · 0 comments · Fixed by #1541
Closed
2 of 3 tasks

[Flamegraph] tweening stopped (regression) #1540

monfera opened this issue Dec 29, 2021 · 0 comments · Fixed by #1541
Labels
bug Something isn't working :flamegraph Flame/Icicle chart related issues :interactions Interactions related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related

Comments

@monfera
Copy link
Contributor

monfera commented Dec 29, 2021 •
edited
Loading

Describe the issue
Flamegraph tweening on click stopped working

To Reproduce
Steps to reproduce the behavior:

  1. Go to the flamegraph story http://localhost:9001/?path=/story/flame-alpha--cpu-profile-flame-chart&globals=theme:light;background:white
  2. Click on a bar
  3. No tweening observed

Expected behaviour
Tweening

Screenshots

Version (please complete the following information):

  • OS: any
  • Browser: any
  • Elastic Charts: as of current main (59002df)

Additional context
Bisected to commit 6db2677 PR #1402

Errors in browser console

Kibana Cross Issues

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • Every related Kibana issue is listed under Kibana Cross Issues list and the kibana cross issue tag is applied
@monfera monfera added bug Something isn't working :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :flamegraph Flame/Icicle chart related issues labels Dec 29, 2021
@monfera monfera changed the title Flamegraph tweening stopped (regression) [Flamegraph] tweening stopped (regression) Dec 29, 2021
@monfera monfera added the :interactions Interactions related issue label Dec 29, 2021
@monfera monfera mentioned this issue Dec 29, 2021
Merged
9 tasks
monfera added a commit that referenced this issue Dec 30, 2021
@monfera
fix(flamegraph): solve animation regression occurring with 6db2677 (#…
5ec6037 
…1541)

Mandatory nature of the internal `animation` property is restored, and the `animation: {duration}` in the chart specification API reaches the render code again

fix #1540
nickofthyme pushed a commit that referenced this issue Jan 5, 2022
@semantic-release-bot @markov00
chore(release): 42.0.0 [skip ci]
d6e6c18 
# [42.0.0](v41.0.1...v42.0.0) (2022-01-05)

### Bug Fixes

* **flamegraph:** solve animation regression occurring with 6db2677 ([#1541](#1541)) ([5ec6037](5ec6037)), closes [#1540](#1540)
* **heatmap:** render empty state ([#1532](#1532)) ([59002df](59002df))
* **waffle:** fix strange 0 text in legend item extra when label is 0 ([#1538](#1538)) ([72224b9](72224b9))

### Features

* **goal:** add valueFormatter for tooltip ([#1529](#1529)) ([8139973](8139973))
* **heatmap:** add axis titles ([#1503](#1503)) ([a87325d](a87325d))
* **types:** improve generic types in specs, and spec prop types ([#1421](#1421)) ([562929e](562929e))

### BREAKING CHANGES

* **types:** The `xAccessor` and `yAccessor` are now required on all xy chart specs. Stronger typing on `data` prop that may cause type errors when using untyped array (i.e. `const arr: never[] = []`). Other minor type changes related to spec types.
* **heatmap:** The heatmap yAxisLabel.padding style type is changed from Pixel | Partial<Padding> to Pixels | Padding. The heatmap axis labels are now correctly subjected to padding calculations and it will result in a slightly different position of labels.

Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working :flamegraph Flame/Icicle chart related issues :interactions Interactions related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(flamegraph): solve animation regression monfera/elastic-charts
1 participant
@monfera