Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show default highlighted radius with hidden dots #679

Closed
nickofthyme opened this issue May 15, 2020 · 1 comment · Fixed by #926
Closed

Show default highlighted radius with hidden dots #679

nickofthyme opened this issue May 15, 2020 · 1 comment · Fixed by #926
Assignees
@markov00
Labels
:data Data/series/scales related issue enhancement New feature or request released Issue released publicly :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented May 15, 2020 •
edited
Loading

Using a line or area series with a MarkAcessor and hidden points should use the default radius highlighter.

Expected behavior
Highlight geometry with hidden point and MarkAccessor should be the default radius size.

Workarounds
You can check for hidden points and decide when to add the MarkAccessor but this would be nice to avoid.

Screenshots
Screen Recording 2020-05-15 at 08 37 AM

Version (please complete the following information):

  • Elastic Charts: latest
@nickofthyme nickofthyme added bug Something isn't working :data Data/series/scales related issue labels May 15, 2020
@nickofthyme nickofthyme self-assigned this May 15, 2020
@nickofthyme nickofthyme reopened this May 15, 2020
@nickofthyme nickofthyme changed the title Wrong highlighted radius when using multiple series Show default highlighted radius with hidden dots May 15, 2020
@nickofthyme nickofthyme added enhancement New feature or request and removed bug Something isn't working labels May 15, 2020
@markov00 markov00 added the :xy Bar/Line/Area chart related label May 29, 2020
@markov00 markov00 mentioned this issue May 29, 2020
Closed
27 tasks
@markov00 markov00 added this to the Kibana 7.10 milestone Aug 26, 2020
@markov00 markov00 modified the milestones: Kibana 7.10, Kibana 7.11 Oct 22, 2020
@markov00 markov00 assigned markov00 and unassigned nickofthyme Nov 30, 2020
markov00 added a commit to markov00/elastic-charts that referenced this issue Nov 30, 2020
@markov00
fix(highlighter): show default highlighted radius with hidden dots
dfa67ae 
This commit fixed the highlighted radius on a line/area point when the markAccessor is configured by
the point visibility on the series is turned off

fix elastic#679
@markov00 markov00 mentioned this issue Nov 30, 2020
Merged
1 task
markov00 added a commit that referenced this issue Nov 30, 2020
@markov00
fix(highlighter): show default highlighted radius with hidden dots (#926
8b167a4 
)

This commit fixed the highlighted radius on a line/area point when the markAccessor is configured by
the point visibility on the series is turned off

fix #679
markov00 pushed a commit that referenced this issue Dec 4, 2020
@semantic-release-bot
chore(release): 24.3.0 [skip ci]
7e4512b 
# [24.3.0](v24.2.0...v24.3.0) (2020-12-04)

### Bug Fixes

* **highlighter:** show default highlighted radius with hidden dots ([#926](#926)) ([8b167a4](8b167a4)), closes [#679](#679)
* **xy_chart:** improve line joins rendering ([#920](#920)) ([ec8041a](ec8041a))
* point highlight based on geom position and transform ([#934](#934)) ([7198b5d](7198b5d))

### Features

* allow no results component, don't require series ([#936](#936)) ([4766c23](4766c23))
* improved domain error handling ([#933](#933)) ([94534a5](94534a5))
@markov00
Copy link
Member

markov00 commented Dec 4, 2020

🎉 This issue has been resolved in version 24.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Dec 4, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 24.3.0 [skip ci]
784b572 
# [24.3.0](elastic/elastic-charts@v24.2.0...v24.3.0) (2020-12-04)

### Bug Fixes

* **highlighter:** show default highlighted radius with hidden dots ([opensearch-project#926](elastic/elastic-charts#926)) ([351c20c](elastic/elastic-charts@351c20c)), closes [opensearch-project#679](elastic/elastic-charts#679)
* **xy_chart:** improve line joins rendering ([opensearch-project#920](elastic/elastic-charts#920)) ([9a6771c](elastic/elastic-charts@9a6771c))
* point highlight based on geom position and transform ([opensearch-project#934](elastic/elastic-charts#934)) ([196ee8d](elastic/elastic-charts@196ee8d))

### Features

* allow no results component, don't require series ([opensearch-project#936](elastic/elastic-charts#936)) ([6be5c8b](elastic/elastic-charts@6be5c8b))
* improved domain error handling ([opensearch-project#933](elastic/elastic-charts#933)) ([f480054](elastic/elastic-charts@f480054))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
:data Data/series/scales related issue enhancement New feature or request released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(highlighter): show default highlighted radius with hidden dots markov00/elastic-charts
2 participants
@markov00 @nickofthyme