Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linked labels overlaps each other #699

Closed
markov00 opened this issue Jun 9, 2020 · 1 comment · Fixed by #726
Closed

Linked labels overlaps each other #699

markov00 opened this issue Jun 9, 2020 · 1 comment · Fixed by #726
Assignees
@monfera
Labels
bug Something isn't working :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Jun 9, 2020

Describe the bug
The link of linked labels overlap in certain condition on Pie Charts

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/cool-chatterjee-uxfj5?file=/src/App.tsx
  2. See the error shown on the screenshot

Expected behaviour
Labels should not overlap but start at different angles

Screenshots
Screenshot 2020-06-09 at 21 50 17

Version (please complete the following information):

  • Elastic Charts: master and before

Additional context
n/a

Errors in browser console
n/a
@markov00 markov00 added bug Something isn't working :partition Partition/PieChart/Donut/Sunburst/Treemap chart related labels Jun 9, 2020
@monfera monfera self-assigned this Jun 29, 2020
@monfera monfera mentioned this issue Jun 29, 2020
Merged
4 tasks
markov00 pushed a commit that referenced this issue Jun 30, 2020
@monfera
fix(partition): linked label on a larger than 180 degree slice (#726)
2504bbe 
This commit fix an issue arose when a single large (>180 degrees) slice is forced to have a linked label, eg. via a large or infinite `maximumSection` value (the default is, fill text)
The root cause was that the preexisting calculation simply took the midpoint of the start and end angle, and if it was shorter to go along the other arc of the circle, then that's what it did. So it always resulted in an exact overlap with two slices where one was over 180 degrees and linked labels were forced.

fix #699
markov00 pushed a commit that referenced this issue Jun 30, 2020
@semantic-release-bot
chore(release): 19.7.0 [skip ci]
2148d2c 
# [19.7.0](v19.6.3...v19.7.0) (2020-06-30)

### Bug Fixes

* **partition:** linked label on a larger than 180 degree slice ([#726](#726)) ([2504bbe](2504bbe)), closes [#699](#699)

### Features

* add domain padding ([#707](#707)) ([15c78c1](15c78c1)), closes [#706](#706)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 19.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jun 30, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.7.0 [skip ci]
0b3d51c 
# [19.7.0](elastic/elastic-charts@v19.6.3...v19.7.0) (2020-06-30)

### Bug Fixes

* **partition:** linked label on a larger than 180 degree slice ([opensearch-project#726](elastic/elastic-charts#726)) ([7ac128e](elastic/elastic-charts@7ac128e)), closes [opensearch-project#699](elastic/elastic-charts#699)

### Features

* add domain padding ([opensearch-project#707](elastic/elastic-charts#707)) ([8084e4b](elastic/elastic-charts@8084e4b)), closes [opensearch-project#706](elastic/elastic-charts#706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monfera monfera

Labels
bug Something isn't working :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(partition): linked label on a larger than 180 degree slice elastic/elastic-charts
2 participants
@markov00 @monfera