-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable APM tracing by default for stack up #1076
Conversation
0e6a0f7
to
1dac32c
Compare
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
🌐 Coverage report
|
++ on having apm enabled in elastic-package by default. I wonder if it would be cleaned to run a separate elastic-agent with the apm-integration. |
I wonder if we should make this somehow optional. This is not required for package development, but adds a source of flakiness. +1 to do it with a separate agent, during testing elastic-package is going to replace the policies used by the default agent, so APM will be likely disabled. |
Agree on using a separate agent and making it optional via the existing |
We don't have any other optional service now (everything is started if the flag is not provided), but this could be an option, yes.
Sounds good, if this is also optional, and not used to test the Kibana and Elasticsearch integrations. |
|
Hi everyone, |
superseded by #1598 |
Turns on tracing by default for all components
TODO:
agent.monitoring.tracing
andagent.monitoring.apm
settings inelastic-agent.yml
didn't workThings that could be improved in future PRs: