Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new flags to just setup, teardown or run tests only #1250
Add new flags to just setup, teardown or run tests only #1250
Changes from 8 commits
20fbf41
adad2d6
d1af618
63ecb86
684ee9b
628216b
681f8af
da5272a
2345470
d86240f
cf23c5d
5add400
58dde46
17542ef
84ea79a
6ad085f
2b6027f
eb23780
f0d955c
e0f2b39
9e0b394
029ad0b
e6e0a7a
13f0c97
d2f3498
7065d57
87c56f5
3e5cb14
efa483e
cff0dd8
bf38069
70cbb3e
53f818d
6cc1ad0
ff62d08
af3e334
deeab20
70ecf7a
9b75ff8
3bc39eb
4868898
cf278fc
739cfb2
ea1a9c7
a085cb6
880ea8f
60220ae
f4baa17
00cd9f8
bb2291a
6a8f797
14cf21a
343c52c
06f7896
df1821d
6f43c70
a9d2b84
9173d9d
273ee15
0b4bda9
d78212b
c3c9565
d0a36ac
23d8ee1
38fb6b6
698bd31
08ad913
0dd2696
ec10a44
d3cea72
3643519
163e42b
667ffab
a3848d5
83da2bd
9c48fee
fe5745b
21c645a
bb0b65c
0b07787
3ec81cc
5305d55
6832cab
0a866ce
27370bb
22ff4b0
be3bb0c
252fef2
dfe5ba8
d14daa4
db82d2f
32ae291
9856557
1393831
7fcad77
4934517
e4e5b81
827c7d7
de6acb3
baad699
90b8e79
bd8acba
40c5c87
f57a653
ee91de4
14e1e2f
5264086
7d4ca6a
d7818bd
7c86cf2
7c43ec9
b22f48a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, this service deployer is not supported. I'd prefer to just leave this option (test flags) for stacks/services started locally for now.
This the error that is going to be shown to the user:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 we can add this later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove the file only, in case we use the directory later for other states. Leaving the directory there should not be a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes totally sense.
Update this function to just delete the file, and update the tests accordingly.