Add required subscription on package creation #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
mrodm
approved these changes
Jul 19, 2022
| Name: "elastic_subscription", | ||
| Prompt: &survey.Select{ | ||
| Message: "Required Elastic subscription:", | ||
| Options: []string{"basic", "gold", "platinum", "enterprise"}, |
There was a problem hiding this comment.
nit: I would change the order to be shown like here
Suggested change
| Options: []string{"basic", "gold", "platinum", "enterprise"}, | |
| Options: []string{"basic", "platinum", "enterprise", "gold"}, |
There was a problem hiding this comment.
Interesting, I didn't know that gold is discontinued, I guess that this is the only reason why it appears later there. But technically platinum > gold, we have been using this order everywhere. See the spec for example: https://github.com/elastic/package-spec/blob/0456e4f000a5bf85130d4e5e9c6d329a627523ec/versions/1/integration/manifest.spec.yml#L54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds by now the old
licensefield and the newelastic.subscriptioncondition.Follow up of elastic/package-spec#355.
Part of elastic/package-spec#298.